fix: improve branch matching for cancelled run cleanup #3939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cleanup script was too strict when matching branch names, causing cancelled runs from merge_queue synthetic branches (e.g., gh-readonly-queue/main/pr-3937-...) to not match newer push runs on main, even though they represent the same branch. Updated the matching logic to treat all main branch runs (including merge_queue synthetic branches) as the same branch. This ensures that any newer run on main will supersede older cancelled ones, regardless of whether they came from a push or merge_queue event. This fixes the issue where cancelled runs from merge_queue weren't being deleted, leaving red X's on main commits.
nishu-builder
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleanup script was too strict when matching branch names, causing cancelled runs from merge_queue synthetic branches (e.g., gh-readonly-queue/main/pr-3937-...) to not match newer push runs on main, even though they represent the same branch.
Updated the matching logic to treat all main branch runs (including merge_queue synthetic branches) as the same branch. This ensures that any newer run on main will supersede older cancelled ones, regardless of whether they came from a push or merge_queue event.
This fixes the issue where cancelled runs from merge_queue weren't being deleted, leaving red X's on main commits.
Asana Task