Remove fractional resource consumption #4061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2025
Merged
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
sasmith
force-pushed
the
sasmith-11-26-remove_resource_mod
branch
from
7e1671e to
a8e07db
Compare
sasmith
force-pushed
the
sasmith-11-26-remove_fractional_resource_consumption
branch
2 times, most recently
from
01391f6 to
d914588
Compare
sasmith
force-pushed
the
sasmith-11-26-remove_resource_mod
branch
from
a8e07db to
d26fddb
Compare
sasmith
force-pushed
the
sasmith-11-26-remove_fractional_resource_consumption
branch
from
d914588 to
bc09d10
Compare
sasmith
force-pushed
the
sasmith-11-26-remove_resource_mod
branch
from
d26fddb to
6e4a0e7
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| using InventoryQuantity = uint8_t; | ||
| using InventoryProbability = float; // probability for fractional consumption | ||
| using InventoryDelta = int16_t; // cover full range of allowed changes (+/-255) | ||
| using InventoryDelta = int16_t; // cover full range of allowed changes (+/-255) |
Contributor
There was a problem hiding this comment.
Removing the InventoryProbability type breaks tests that rely on fractional consumption. Either the tests need to be updated or this type should be kept for backward compatibility.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
nathants
approved these changes
Nov 27, 2025
Contributor
nathants
left a comment
nathants
left a comment
There was a problem hiding this comment.
Do it. Tests are significantly red, but you are probably either fixing that or fixing it in the branch that merges all these mini prs?
sasmith
force-pushed
the
sasmith-11-26-remove_resource_mod
branch
from
6e4a0e7 to
b9e94f5
Compare
sasmith
force-pushed
the
sasmith-11-26-remove_fractional_resource_consumption
branch
from
bc09d10 to
2e29844
Compare
sasmith
force-pushed
the
sasmith-11-26-remove_fractional_resource_consumption
branch
from
2e29844 to
8bbf701
Compare
sasmith
deleted the
sasmith-11-26-remove_fractional_resource_consumption
branch
zfogg
pushed a commit
that referenced
this pull request
Dec 20, 2025
Replaced probabilistic resource consumption with deterministic consumption by changing `InventoryProbability` (float) to `InventoryQuantity` (int) throughout the codebase. This is part of removing floats from the simulation. For features that are in active use, I'm aiming to replace floating calculations with integer calculations. For features that aren't in active use, I'm just removing the feature. https://app.asana.com/1/1209016784099267/project/1209096222434381/task/1211547145607801?focus=true --------- Co-authored-by: S. Alex Smith <sasmith@stem.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced probabilistic resource consumption with deterministic consumption by changing
InventoryProbability(float) toInventoryQuantity(int) throughout the codebase.This is part of removing floats from the simulation. For features that are in active use, I'm aiming to replace floating calculations with integer calculations. For features that aren't in active use, I'm just removing the feature.
https://app.asana.com/1/1209016784099267/project/1209096222434381/task/1211547145607801?focus=true