[MettaScope] sort protocols in UI by hearts #4108
Conversation
monofuel
commented
Dec 1, 2025
monofuel
commented
- https://app.asana.com/1/1209016784099267/project/1209513563278644/task/1212076117461974
- show protocols with more hearts first, then fewer
- after hearts, show other recipes in any order.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| proc getHeartCount(outputs: seq[ItemAmount], itemNames: seq[string]): int = | ||
| ## Returns total hearts produced by this protocol. | ||
| for output in outputs: | ||
| if output.itemId == 5: # "heart" item | ||
| return output.count |
There was a problem hiding this comment.
The new getHeartCount checks for output.itemId == 5, but the replay item names place "heart" at index 4 by default (see replays.nim item_names list), and other replays may order items differently. As a result the helper returns 0 for actual heart outputs, so the sort comparator treats heart-producing protocols as non-heart and the UI never promotes them; the Asana requirement to show higher-heart recipes first fails whenever the heart item id is not exactly 5 (the default case).
Useful? React with 👍 / 👎.
- https://app.asana.com/1/1209016784099267/project/1209513563278644/task/1212076117461974 - show protocols with more hearts first, then fewer - after hearts, show other recipes in any order. <img width="588" height="664" alt="Screenshot From 2025-12-01 16-20-28" src="https://github.com/user-attachments/assets/064facb5-d54e-4009-a93d-101c932c9a93" />
