feat(gridworks): Quick navigation on config and mission view #4154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eckhardt-D
commented
Dec 3, 2025
Contributor
Author
Eckhardt-D
left a comment
Eckhardt-D
left a comment
There was a problem hiding this comment.
Some self-review items
Eckhardt-D
changed the title
berekuk
requested changes
Dec 4, 2025
Removes unused dangling prop, idiomatic config loop. Better sizing of select, make EditableNode more generic.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Eckhardt-D
commented
Dec 5, 2025
berekuk
reviewed
Dec 5, 2025
gridworks/src/app/cogames/missions/view/[name]/MissionTitle.tsx
Outdated
Show resolved
Hide resolved
berekuk
approved these changes
Dec 6, 2025
Contributor
berekuk
left a comment
berekuk
left a comment
There was a problem hiding this comment.
I thought I approved last time, my bad
zfogg
pushed a commit
that referenced
this pull request
Dec 20, 2025
Adds ability to edit the config title, which opens a list of all other configs, when typing starts configs are filtered based on whether it contains the typed text. - Doesn't immediately filter on the active name to see full list of other configs - Resets on blur - Clicking (or Enter) on config name navigates to that view - Can navigate with arrow keys to select option TODO: - [x] If approach makes sense, replicate in the missions view <img width="690" height="280" alt="image" src="https://github.com/user-attachments/assets/1778b3d3-6d5e-4745-864b-93a7f4623d1f" /> <img width="744" height="448" alt="image" src="https://github.com/user-attachments/assets/ece710c2-9cdc-400d-9f3c-7420aede3767" /> <img width="534" height="331" alt="image" src="https://github.com/user-attachments/assets/51c474cd-6abe-4738-83d5-7fef4b4bae05" /> [Asana Task](https://app.asana.com/1/1209016784099267/project/1210348820405981/task/1212304005487515) [Asana Task](https://app.asana.com/1/1209016784099267/project/1210006613945419/task/1212210337332221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to edit the config title, which opens a list of all other configs, when typing starts configs are filtered based on whether it contains the typed text.
TODO:
Asana Task
Asana Task