Observatory backend uses pydantic BaseSettings for marshalling env vars for its settings #4290
Conversation
…rs for its settings
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| class Settings(BaseSettings): | ||
| STATS_DB_URI: str = "postgres://postgres:password@127.0.0.1/postgres" | ||
| DEBUG_USER_EMAIL: str | None = None | ||
| OBSERVATORY_AUTH_SECRET: str | None = None |
There was a problem hiding this comment.
Config values were moved into a Settings object (config.py lines 4‑7), so the module no longer exposes debug_user_email. Several tests and fixtures still patch metta.app_backend.config.debug_user_email to bypass auth (e.g., app_backend/tests/conftest.py:25–28, test_leaderboard_routes.py:182, test_sweep_routes.py:101); with the attribute gone those patches now raise AttributeError during import, causing the app_backend test suite to fail and removing the intended debug override path.
Useful? React with 👍 / 👎.
nishu-builder
deleted the
nishad/app-backend-uses-pydantic-for-env-config-marshalling
branch
…rs for its settings (#4290) For cleanliness' sake
For cleanliness' sake