Better serializing/deserializing of PolicyEnvInterface #4292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/mettagrid/python/src/mettagrid/policy/policy_env_interface.py
Outdated
Show resolved
Hide resolved
rhysh
reviewed
Dec 9, 2025
Comment on lines
43
to
47
| return gym.spaces.Box( | ||
| low=np.array(v["low"]), | ||
| high=np.array(v["high"]), | ||
| dtype=dtype, # type: ignore[arg-type] | ||
| ) |
Contributor
There was a problem hiding this comment.
Where does "shape" show up? In practice, I see these (when formatted as strings) looking like Box(0, 255, (200, 3), uint8).
Contributor
|
There may be a better way to serialize the observation_space, but this seems to be working. Thanks! |
rhysh
approved these changes
Dec 9, 2025
nishu-builder
deleted the
nishad/better-serializing-of-policy-env-interface
branch
zfogg
pushed a commit
that referenced
this pull request
Dec 20, 2025
Use custom (de)serializers for gym objects that show up in PolicyEnvInterface. Then we can pass it and receive it over the wire via json, which is important to getting policies initialized in separate processes from the one that forms the PolicyEnvInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use custom (de)serializers for gym objects that show up in PolicyEnvInterface. Then we can pass it and receive it over the wire via json, which is important to getting policies initialized in separate processes from the one that forms the PolicyEnvInterface