feat(transactions): Add Transaction Fees Calculation (#358)#500
Open
solomonokeke012-bot wants to merge 2 commits intoMettaChain:mainfrom
Open
feat(transactions): Add Transaction Fees Calculation (#358)#500solomonokeke012-bot wants to merge 2 commits intoMettaChain:mainfrom
solomonokeke012-bot wants to merge 2 commits intoMettaChain:mainfrom
Conversation
- Add TransactionFeesService: platform fee (1.5%), agent commission (3%), tax (8%) - Add fee breakdown endpoint: POST /transactions/fees/calculate - Add GET /transactions/:id/fees to fetch a transaction with its fee breakdown - Add TransactionsController and TransactionsService with CRUD endpoints - Register TransactionsModule in AppModule - 4 unit tests covering standard, custom rate, zero amount, and rounding
|
@solomonokeke012-bot Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@solomonokeke012-bot please check the CI. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements transaction fees calculation as required by issue #358.
What's included
TransactionFeesService— pure fee calculation logic:FeeBreakdownwith all rates and totalsTransactionsController— REST endpoints:POST/transactions/fees/calculatePOST/transactionsGET/transactionsGET/transactions/:idGET/transactions/:id/feesTransactionsModuleregistered inAppModuleTests
4 unit tests covering:
Tested
npm run buildsucceeds with no TypeScript errorsCloses #358