Conversation
also new poop log message
This was
linked to
issues
Apr 7, 2026
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds automatic AI session title generation: when a new conversation has empty history, the grok handler requests a concise title from a TitleGen persona, then persists it to the DB. Also adds title storage to the schema, a helper to generate titles, minor UI text and avatar/webhook handling tweaks. Changes
Sequence DiagramsequenceDiagram
participant Handler as Grok Handler
participant AI as OpenRouter (TitleGen)
participant DB as Database
Handler->>Handler: Receive user message / determine session
Handler->>DB: attempt db.aiChat.getHistory(sessionId)
Handler->>Handler: Append user + assistant messages to history
alt historyLoaded && history.length === 0
Handler->>AI: generateSessionTitle(userMessage, aiResponse)
AI-->>Handler: Return title (or null)
alt title returned
Handler->>DB: updateTitle(sessionId, title)
DB-->>Handler: Acknowledgement
end
end
Handler-->>Handler: Continue normal flow
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
database/queries/aiChatQueries.ts (1)
17-17: Make the title update idempotent.Because the “first message” decision is made before this write, two concurrent first turns can both reach Line 17 and last-writer-wins the title. Guarding the update with
AND title IS NULLkeeps the first generated title stable.Possible SQL tweak
- UPDATE_SESSION_TITLE: 'UPDATE AiChatSession SET title = ? WHERE session_id = ?', + UPDATE_SESSION_TITLE: 'UPDATE AiChatSession SET title = ? WHERE session_id = ? AND title IS NULL',🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@database/queries/aiChatQueries.ts` at line 17, The UPDATE_SESSION_TITLE SQL should be made idempotent so concurrent “first message” writes don't race; update the string constant UPDATE_SESSION_TITLE in aiChatQueries.ts to include a guard like "AND title IS NULL" (i.e., only set title when it's currently NULL) so only the first writer wins and subsequent concurrent updates are no-ops.classes/silverwolf.ts (1)
290-296: Fallback when the referenced member can't be fetched.Line 294 can still reject for quoted users who left the guild or can't be fetched, which means the temporary
Generating...reply never gets replaced. Falling back toperson.usernamekeeps the quote path resilient for that case too.Possible hardening
if (referencedMessage.webhookId) { nickname = referencedMessage.author.username; } else { - const guildMember = await message.guild.members.fetch(referencedMessage.author.id); - nickname = guildMember.nickname || person.username; + try { + const guildMember = await message.guild.members.fetch(referencedMessage.author.id); + nickname = guildMember.nickname || person.username; + } catch { + nickname = person.username; + } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@classes/silverwolf.ts` around lines 290 - 296, The fetch of the referenced guild member (used to set nickname) can throw if the quoted user left or can't be fetched; update the logic around message.guild.members.fetch(referencedMessage.author.id) so it is wrapped in a try/catch (or use .catch) and on any failure fall back to person.username; ensure the variable nickname still gets assigned either guildMember.nickname || person.username when fetch succeeds or person.username when it fails so the temporary "Generating..." reply is always replaced.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@classes/handlers/keywordsBehaviorHandler.ts`:
- Around line 230-241: The code wrongly treats an empty history array as a
signal of a new session even when getHistory() may have failed; add a boolean
flag (e.g., historyLoaded) that is set true only when getHistory() completes
successfully and only run the title-generation block when historyLoaded is true
and history.length === 0; update the logic around getHistory(), the history
variable, and the async title-generation block (references: getHistory(),
history, generateSessionTitle(), aiChat.updateTitle(), aiSession.sessionId) so
transient read failures do not cause a new title to be generated or persisted.
In `@utils/ai.ts`:
- Around line 241-259: The model output from generateSessionTitle must be
normalized and size-limited before returning: after getting
completion.choices?.[0]?.message?.content, collapse all whitespace/newlines into
single spaces, trim ends, then truncate to a safe length (e.g., limit to 10
words or ~80 characters) and ensure it is a single-line string; return null if
the normalized result is empty. Update generateSessionTitle to perform this
normalization/clamping (use the persona variable and the completion result from
openrouter.chat.completions.create to locate where to apply the change).
---
Nitpick comments:
In `@classes/silverwolf.ts`:
- Around line 290-296: The fetch of the referenced guild member (used to set
nickname) can throw if the quoted user left or can't be fetched; update the
logic around message.guild.members.fetch(referencedMessage.author.id) so it is
wrapped in a try/catch (or use .catch) and on any failure fall back to
person.username; ensure the variable nickname still gets assigned either
guildMember.nickname || person.username when fetch succeeds or person.username
when it fails so the temporary "Generating..." reply is always replaced.
In `@database/queries/aiChatQueries.ts`:
- Line 17: The UPDATE_SESSION_TITLE SQL should be made idempotent so concurrent
“first message” writes don't race; update the string constant
UPDATE_SESSION_TITLE in aiChatQueries.ts to include a guard like "AND title IS
NULL" (i.e., only set title when it's currently NULL) so only the first writer
wins and subsequent concurrent updates are no-ops.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0ce19195-3037-4d29-8593-177fe963dcd0
📒 Files selected for processing (10)
classes/handlers/keywordsBehaviorHandler.tsclasses/silverwolf.tscommands/ai_view.tscommands/poop_log.tsdata/aiPersonas.jsondatabase/models/AiChatModel.tsdatabase/queries/aiChatQueries.tsdatabase/tables/aiChatSessionTable.tsutils/ai.tsutils/quote.ts
Collaborator
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also new poop log message
Summary by CodeRabbit
New Features
Improvements
UI Updates