feat: implement pawn promotion with move generation and validation#1
Merged
feat: implement pawn promotion with move generation and validation#1
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements pawn promotion functionality for the chess engine, allowing pawns to be promoted to Queen, Rook, Bishop, or Knight when reaching the 8th rank (for White) or 1st rank (for Black). This completes Slice 8 of the chess engine foundation specification.
Key Changes
- Updated move generation to create 4 separate promotion moves (Q, R, B, N) for each pawn reaching the promotion rank
- Added validation in
MakeMove()to require a promotion piece when a pawn reaches the promotion rank - Implemented promotion logic in
applyMove()to replace the pawn with the promoted piece
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/engine/moves.go | Added promotion logic to generatePawnMoves() for both forward moves and captures, generating 4 moves per promotion scenario |
| internal/engine/board.go | Added promotion validation in MakeMove() and promotion execution in applyMove() |
| internal/engine/moves_test.go | Added comprehensive test suite covering promotion move generation, all 4 promotion types, captures, error cases, and both colors |
| context/spec/001-chess-engine-foundation/tasks.md | Marked Slice 8 tasks as completed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.