Guard all mutating public API methods against post-finalization calls#16
Merged
MichaConrad merged 2 commits intomainfrom Feb 24, 2026
Merged
Guard all mutating public API methods against post-finalization calls#16MichaConrad merged 2 commits intomainfrom
MichaConrad merged 2 commits intomainfrom
Conversation
…n + unit tests Co-authored-by: MichaCo <5837539+MichaCo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add check for finalized state in Triangulation API
Guard all mutating public API methods against post-finalization calls
Feb 24, 2026
SummarySummary
CoverageCDT.Core - 85.1%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After any
Erase*method is called, the triangulation is finalized and further mutation (vertex/edge insertion or additional erase calls) leads to silent index-out-of-range errors rather than a clear failure. This adds early, explicit rejection for all affected methods.Changes
Triangulation.csTriangulationFinalizedException(derives fromTriangulationException) with a descriptive messageIsFinalizedguard at the top of every mutating public method:InsertVertices,InsertEdges,ConformToEdges,EraseSuperTriangle,EraseOuterTriangles,EraseOuterTrianglesAndHolesTriangulationTests.csTriangulationFinalizedExceptionis thrown post-finalization (runs for bothfloatanddoublevia the shared base class)Example
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.