Improving Nameserver suffix handling #207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* better impl for TCP connection timeouts
antonfirsov
reviewed
Mar 11, 2024
| private static ushort GetRandom() | ||
| { | ||
| var block = new byte[2]; | ||
| s_generator.GetBytes(block); |
Contributor
There was a problem hiding this comment.
RandomNumberGenerator instance methods are not guaranteed to be thread safe, even though they might be in practice.
Owner
Author
|
splitting this into separated PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.Contains(string)to DnsString to, for example, find a namespace within a query string.For more details, see #198 and the MiniDig change here which does an example of how to find nameservers using the new
Containsetc...