Skip to content

Fixed 'Setup SSH' issues#90

Merged
MichaelKoster70 merged 4 commits intomainfrom
bugfix/setup-ssh-port
Dec 30, 2025
Merged

Fixed 'Setup SSH' issues#90
MichaelKoster70 merged 4 commits intomainfrom
bugfix/setup-ssh-port

Conversation

@MichaelKoster70
Copy link
Copy Markdown
Owner

@MichaelKoster70 MichaelKoster70 commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issues in the SSH setup functionality by improving error handling and adding a fallback mechanism for server fingerprint acceptance. The key improvements include enhanced logging throughout the SSH connection process, implementing a secondary method using direct SSH connections when ssh-keyscan fails, and fixing a validation bug that previously allowed empty port numbers.

Key Changes:

  • Added fallback SSH connection method when ssh-keyscan fails to retrieve server fingerprints
  • Fixed port validation to prevent empty values from being accepted
  • Enhanced logging and error reporting throughout the SSH setup workflow

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Resources.resx Added new localized strings for enhanced logging messages and error reporting in SSH setup
SetupSshDialogWindow.xaml.cs Added exception filter callback to capture binding validation errors for port field
SetupSshDialogWindow.xaml Updated port TextBox binding to include exception validation and custom error filter
HostPortValidationRule.cs Enhanced validation logic to reject empty port values and handle both string and integer inputs
SetupSshViewModel.cs Added method to report binding exceptions and integrated validation error checking in command execution
SecureShellKeySetupService.cs Implemented fallback SSH connection method for fingerprint acceptance and refactored fingerprint registration into separate methods
RemoteDebuggerLauncher.csproj Added references to new infrastructure classes for pseudo console and string handling
PackageConstants.cs Added constants for SSH executable and arguments used in fallback connection method
StringBuilderExtensions.cs New utility class to strip ANSI/VT escape sequences from console output
PseudoConsoleProcess.cs New class implementing Windows pseudo console for interactive SSH sessions
NativeMethods.cs New class with P/Invoke declarations for Windows console and process creation APIs
Files not reviewed (1)
  • src/Extension/RemoteDebuggerLauncherUI/Resources.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Extension/RemoteDebuggerLauncherUI/Commands/ViewModels/SetupSshViewModel.cs Outdated
Comment thread src/Extension/RemoteDebuggerLauncher/Infrastructure/PseudoConsoleProcess.cs Outdated
MichaelKoster70 and others added 2 commits December 30, 2025 14:48
…upSshViewModel.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…oleProcess.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@MichaelKoster70 MichaelKoster70 merged commit 6a40a7e into main Dec 30, 2025
5 checks passed
@MichaelKoster70 MichaelKoster70 deleted the bugfix/setup-ssh-port branch December 30, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSH Connection Issue: "Could not resolve hostname"

2 participants