Extract handler store layer, fix N+1 test result inserts#232
Merged
Conversation
added 11 commits
April 13, 2026 23:51
…s.go, eliminate field-by-field adapter conversions, remove empty benchmark
…r, remove dead code, add handler unit tests - Auth, executions, analytics, reports, admin, and quality-gates handlers now use store interfaces exclusively instead of raw *db.Pool SQL queries - Removed adapter structs; assign concrete *store.XxxStore directly (following existing teams/webhooks pattern) - Fixed LinkReport empty teamID bug (was passing empty string, now takes proper teamID parameter) - Removed dead code: BulkInsertTestResults, AuthDBTX, nullString duplication - TrendRow.PassRate now populated by SQL query (CASE expression) instead of being left as zero - Added store-based unit tests for auth handler (12 tests with mockAuthStore) and executions handler (28 tests with mockExecutionsStore) - Deduplicated nullString: moved to store.NullString shared helper - All handler tests pass; no regressions
…te ErrorCluster slice
…use indexed assignment in ErrorAnalysis
… add bulk insert tests
…face and DB() from OAuthStore, remove duplicate webhook check in test
…FromURL helper, remove IsNoRows wrapper, remove obvious comments
…re layer extraction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes droplet sc-ccb46.