Skip to content

Fix for identity rates #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravigadila merged 2 commits into from
Feb 27, 2017
Merged

Fix for identity rates #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa11159
Fix for identity rates
sposs Feb 27, 2017
7c4274b
Add test
sposs Feb 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions forex_python/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ def get_rates(self, base_cur, date_obj=None):
raise RatesNotAvailableError("Currency Rates Source Not Ready")

def get_rate(self, base_cur, dest_cur, date_obj=None):
if base_cur == dest_cur:
return 1.
date_str = self._get_date_string(date_obj)
payload = {'base': base_cur, 'symbols': dest_cur}
source_url = self._source_url() + date_str
Expand Down
5 changes: 5 additions & 0 deletions tests/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ def test_get_rate_with_valid_codes(self):

# check if return value is float
self.assertTrue(isinstance(rate, float))

def test_get_rate_with_valid_codes_same_currency(self):
rate = get_rate('USD', 'USD')
# rate should be 1.
self.assertEqual(1., rate)

def test_get_rate_with_date(self):
date_obj = datetime.datetime.strptime('2010-05-10', "%Y-%m-%d").date()
Expand Down