Correct pff2port idx converter for VEP inst #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChetaN KS <chetankumar.sanga@microchip.com>
vaibhaavram01
approved these changes
Dec 17, 2025
pvengat
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, events -a command on UART interface after converting PFF to Port index, it does gasrd, but for VEP instances the reader should mask Byte0 in read value as done in kernel driver counterpart for VEP instance.
VEP read values from UART containing 16 bit number which doesnt match 8-bit masked expected register value.
e.g. reg = gasrd(..) gives reg as 0x5104, while pff index is simply 0x4. so compare fails and perrors occur.
By masking Byte0 (i.e. reg = gasrd(...) & 0xffU), we ensure proper index value is taken.
With this change, events -a on UART doesn't fail with p22toport perror anymore.