remove warning from rdSHT21#2
Open
Basti-iTAS-PLMS wants to merge 3 commits intomainfrom
Open
Conversation
compiler complained about wrong parameter type (uint8_t* instead of uint16_t*). Fixed this by changing the parameter's type and usage of bit shifting instead of array access. Downside is an additional command. Is this an issue @VSK-THU?
Member
Author
|
If suggested change is acceptable, I will update SHT21 lib (can you again tell me where to find latest version?) and add the fix. |
added 2 commits
January 10, 2025 20:46
according to the datashet, the sensors response contains two status bits. Bit 0 and 1 of the measurement. Thus, those two need to be masked out. See chapter 5.4 in the bottom right paragraph
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compiler complained about wrong parameter type (uint8_t* instead of uint16_t*). Fixed this by changing the parameter's type and usage of bit shifting instead of array access. Downside is an additional command. Is this an issue @VSK-THU?