add memory barrier between set dma target address and enable dma#36
Merged
wesleywesley merged 1 commit intodevelfrom Sep 18, 2018
Merged
add memory barrier between set dma target address and enable dma#36wesleywesley merged 1 commit intodevelfrom
wesleywesley merged 1 commit intodevelfrom
Conversation
in mrpc dma mode, dma target address register with offset 0x810-0x817 and mrpc dma mode enable register with offset 0x80c in gas space driver set the dma target address register first, then enable mrpc dma mode following, but because mrpc section with WC attribute, these 2 writes were combined and resulting enable dma first then followed by the dma target address, that's 3 dwords write from 0x80c to 0x817, add the necessory barrier between the memory barrier also added when disable mrpc dma
lsgunth
approved these changes
Sep 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in mrpc dma mode, dma target address register with offset
0x810-0x817 and mrpc dma mode enable register with offset 0x80c in
gas space
driver set the dma target address register first, then
enable mrpc dma mode following, but because mrpc section with WC
attribute, these 2 writes were combined and resulting enable dma
first then followed by the dma target address, that's 3 dwords write
from 0x80c to 0x817, add the necessory barrier between
the memory barrier also added when disable mrpc dma