switchtec: Fix unintended mask of MRPC event#52
Merged
wesleywesley merged 1 commit intodevelfrom Dec 17, 2018
Merged
Conversation
Collaborator
|
If two events other than MRPC was generated at the same time. There's no such issue. The description is a little bit confusing. I think this case is when a MRPC completion event and one or mor other events happened to be handled in the same interrupt handling, the MRPC completion would be disabled unintentionally. Since there's no chance to enable it again, all the following MRPC execution completion check will be defer to a timeout. Add I'd also suggest add description of the problem we observed at the beginning. |
wesleywesley
force-pushed
the
mrpc_msi_dis
branch
from
e0e7aac to
fba7b8a
Compare
Contributor
Author
|
@kelvin-cao |
kelvin-cao
approved these changes
Dec 14, 2018
There exists a corner case: MRPC completion event happened immediately after other non-MRPC event, moreover exactly right after MRPC event occurrence check but before the mask event loop reach to its header register in event ISR, the MRPC event would be masked unintentionally. Since there's no chance to enable it again except module remove and install, all the following MRPC execution completion check will be defer to timeout. Fix this bug by bypass the mask operation same as to LINK event in event ISR. This corner case was exposed by concurrently running fw-update and event-wait commands of switchtec-user. When it happened, firmware update speed reduce evidently. Signed-off-by: Wesley Sheng <wesley.sheng@microchip.com>
lsgunth
approved these changes
Dec 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of two or more events happened simultaneously, MRPC event
maybe masked which lead to no more interrupt for this event,
before the next module remove and install.
In this situation, polling in 500ms time interval instead of
interrupt is leveraged, therefore the MRPC execution respond speed
is lower down evidently.
Fix this issue by skip the mask operation same as LINK event.
Reported-by: Susan He susan.he@microchip.com
Signed-off-by: Wesley Sheng wesley.sheng@microchip.com