Devel unified clean#69
Merged
kelvin-cao merged 5 commits intoMicrosemi:develfrom Jun 14, 2019
Merged
Conversation
Add a generation variable passed through the device id table. Will add generation 4 and other devices after they are functionally supported. Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Since gen4 system info region in GAS is diverged from gen3, seperate oute the gen3 specific stuff in preparation for adding a gen4 variant. Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Add a union with gen3 and gen4 sys_info structs. Ensure any use of the gen3 struct is gaurded by an if statement on stdev->gen. Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Add a union with gen3 and gen4 flash_info structs. Signed-off-by: Kelvin Cao <kelvin.cao@microchip.com>
Closed
lsgunth
reviewed
May 24, 2019
| #define SWITCHTEC_EVENT_EN_CLI BIT(2) | ||
| #define SWITCHTEC_EVENT_EN_IRQ BIT(3) | ||
| #define SWITCHTEC_EVENT_FATAL BIT(4) | ||
| #define SWITCHTEC_EVENT_NOT_SUPP BIT(31) |
Collaborator
There was a problem hiding this comment.
This bit is not set anywhere and therefore not used. You should not merge commits that are not used by anything.
Collaborator
Author
There was a problem hiding this comment.
I removed this patch and forced pushed the series. Will add this back when firmware is ready.
Signed-off-by: Kelvin Cao <kelvin.cao@microchip.com>
kelvin-cao
force-pushed
the
devel_unified_clean
branch
from
a02fa23 to
9411b22
Compare
lsgunth
approved these changes
Jun 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These patchtes have been reviewed with Logan.