Proposed fix for Issue #74 "Need support for Linux AER driver's recovery sequence for fatal AERs"#75
Merged
kelvin-cao merged 1 commit intoMicrosemi:develfrom Dec 4, 2019
Conversation
lsgunth
approved these changes
Sep 12, 2019
Collaborator
lsgunth
left a comment
lsgunth
left a comment
There was a problem hiding this comment.
Thanks! This looks good to me. Probably worth cleaning up the patch and sending it to the upstream kernel.
Collaborator
|
Should probably squash those, commits: no sense reviewing one commit that gets fixed in a subsequent commit. But otherwise, still looks fine to me. |
…ery sequence for fatal AERs" - In probe routine save PCI device state and enable PCI error reporting. - Add "error_detected" entry point for AER recovery, which disables PCI device before link reset. - Add "slot_reset" entry point for AER recovery, which re-initializes and re-enables PCI device after link reset. - Add "resume" entry point for AER recovery, which does AER cleanup for PCI device.
dinderieden
force-pushed
the
aer_recovery_handling
branch
from
7294365 to
6736a6f
Compare
Contributor
Author
|
OK, I've squashed the commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to Issue #74 for problem description. Fix includes: