Skip to content

Added NT BAR Setup Extension Registers for large MWs#9

Merged
wesleywesley merged 1 commit intoMicrosemi:develfrom
PaulSelles:master
Jun 11, 2018
Merged

Added NT BAR Setup Extension Registers for large MWs#9
wesleywesley merged 1 commit intoMicrosemi:develfrom
PaulSelles:master

Conversation

@PaulSelles
Copy link
Copy Markdown
Contributor

For direct memory windows greater than (4G-4K), the BAR Setup Extension Registers need to be used.

This pull request was created to resolve the 4G issue in Issue 8: MW 2M limitation

For direct memory windows greater than (4G-4K), the BAR Setup Extension Registers need to be used.
@PaulSelles PaulSelles mentioned this pull request May 13, 2018
@lsgunth
Copy link
Copy Markdown
Collaborator

lsgunth commented May 14, 2018

Looks good to me. Thanks!

@glimchb
Copy link
Copy Markdown
Contributor

glimchb commented May 16, 2018

Please merge

@lsgunth lsgunth requested a review from wesleywesley May 21, 2018 20:22
@glimchb
Copy link
Copy Markdown
Contributor

glimchb commented May 29, 2018

@wesleywesley - please review and merge

@PaulSelles PaulSelles changed the base branch from master to devel May 30, 2018 05:49
@glimchb
Copy link
Copy Markdown
Contributor

glimchb commented May 31, 2018

@wesleywesley - please review and merge

@wesleywesley
Copy link
Copy Markdown
Contributor

Actually, we have review the code internally.
But before the code merge, we will verify on EVB.

@glimchb
Copy link
Copy Markdown
Contributor

glimchb commented May 31, 2018

@wesleywesley ok, thanks. good to know.
I already verified it on my machine... you can also go ahead and verify it on EVB as well

@wesleywesley
Copy link
Copy Markdown
Contributor

@glimchb would you pls tell me the FW version and configure file you used for verification. I will setup the test environment and verified in my place.

@glimchb
Copy link
Copy Markdown
Contributor

glimchb commented Jun 3, 2018

@wesleywesley this is the FW version:

$ switchtec fw-info 0

Currently Running:
  IMG Version: 1.08 BD58
Active Partition:
  BOOT 	Version: 1.08 BD58	CRC: 725a8d2e   (RO)
  IMG  	Version: 1.08 BD58	CRC: 3b0e90b2	(Running)
  CFG  	Version: 1.08 B3F08	CRC: 9efdc91b	(Running)
Inactive Partition:
  IMG  	Version: 1.08 BD58	CRC: 3b0e90b2
  CFG  	Version: 1.08 B3F08	CRC: 60c359aa

For the configuration: I just enlarged the BAR2/4 to 16G to test...
See it attached here: 16g.zip

@glimchb
Copy link
Copy Markdown
Contributor

glimchb commented Jun 6, 2018

@lsgunth will this work be also take upstream?

@lsgunth
Copy link
Copy Markdown
Collaborator

lsgunth commented Jun 8, 2018

I hope so. I don't know who's responsible for that anymore.

@glimchb
Copy link
Copy Markdown
Contributor

glimchb commented Jun 10, 2018

@lsgunth Isn't it a straight forward approach just to send a patch to linux-ntb@googlegroups.com ?
@PaulSelles could you please send it ?

@PaulSelles
Copy link
Copy Markdown
Contributor Author

@glimchb I'll look into this.

@lsgunth FYI you are still listed as one of the maintainers https://www.kernel.org/doc/linux/MAINTAINERS

@wesleywesley wesleywesley merged commit d139906 into Microsemi:devel Jun 11, 2018
@lsgunth
Copy link
Copy Markdown
Collaborator

lsgunth commented Jun 11, 2018

Yes, I'm still maintainer and have been acting as such: reviewing patches that hit the lists concerning the switchtec code. Anyone is free to send the patch upstream and I'll review it there (you'll definitely want to expand the commit message significantly, though, and it must have a sign-off from the author).

At an appropriate time someone should be collecting all the changes on github and sending patches upstream. The best time would be next week when the merge window ends. If Microsemi is interested in contracting me for this type of maintenance I'd be happy to do it, otherwise I'll stick to a reviewing role.

Logan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants