Update the way of getting vep instance id #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsgunth
approved these changes
Jul 31, 2020
Collaborator
lsgunth
left a comment
lsgunth
left a comment
There was a problem hiding this comment.
One nit, otherwise it looks fine to me.
ntb_hw_switchtec.c
Outdated
| pff = ioread32(&stdev->mmio_part_cfg_all[partition].vep_pff_inst_id); | ||
| if (pff == 0xFFFFFFFF) { | ||
| pff = ioread32(&stdev->mmio_part_cfg_all[partition].vep_pff_inst_id) | ||
| & 0xFF; |
Collaborator
There was a problem hiding this comment.
Nit: this line break is really ugly. Maybe just add pff &= 0xFF; on it's own line.
Collaborator
Author
There was a problem hiding this comment.
Updated. Thanks.
per firmware change. Firmware updated the GAS field VEP_PFF_INST_ID in partition region to add DMA EP and NVMe EP support. Update the drivers accordingly.
kelvin-cao
force-pushed
the
vep_inst_id_fix
branch
from
756cf36 to
99fccbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per firmware change. Firmware updated the GAS field VEP_PFF_INST_ID
in partition region to add DMA EP and NVMe EP support. Update the
drivers accordingly.