Fix firmware download command errors #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-cao
reviewed
Nov 11, 2020
nvme.c
Outdated
| buf = fw_buf; | ||
| if (cfg.xfer == 0 || cfg.xfer % 4096) | ||
| cfg.xfer = 4096; | ||
| if (cfg.xfer == 0 || cfg.xfer % 512 || cfg.xfer > 512) |
Collaborator
There was a problem hiding this comment.
Does it mean for whatever cfg.xfer's value, we'll assign it to 512?
Collaborator
Author
There was a problem hiding this comment.
Yes that's what it does. I wanted to change it to cfg.xfer=512 but decided to keep it in case we support other size later.
Collaborator
Author
There was a problem hiding this comment.
Updated with cfg.xfer=512.
This is due to a limitation in Switchtec that only <1024 byte chunk size is supported. 512 is the largest number that works for this command.
xyan264
force-pushed
the
fw-download-fix
branch
from
70a0e08 to
18a5338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a limitation in Switchtec firmware,
fw-downloadcommand can only support chunk size <1024 bytes.512 has been found to be the maximum chunk size that currently works with
fw-downloadcommand.