Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

pass username to webchat#1353

Merged
cwhitten merged 4 commits into
microsoft:masterfrom
a-b-r-o-w-n:fix-missing-username
Mar 7, 2019
Merged

pass username to webchat#1353
cwhitten merged 4 commits into
microsoft:masterfrom
a-b-r-o-w-n:fix-missing-username

Conversation

@a-b-r-o-w-n
Copy link
Copy Markdown
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Mar 6, 2019

fixes #1350

Fixed

  • [client] Pass along user name to webchat in PR #1353

tonyanziano
tonyanziano previously approved these changes Mar 6, 2019
Comment thread packages/app/client/src/ui/editor/emulator/parts/chat/chat.tsx Outdated
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 7, 2019

Pull Request Test Coverage Report for Build 2166

  • 2 of 5 (40.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 54.956%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/ui/editor/emulator/parts/chat/chatContainer.ts 1 4 25.0%
Totals Coverage Status
Change from base Build 2165: -0.02%
Covered Lines: 4868
Relevant Lines: 8318

💛 - Coveralls

@cwhitten cwhitten merged commit eb85892 into microsoft:master Mar 7, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the fix-missing-username branch March 8, 2019 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

With BOT Emulator 4.3.0 no "name" is provided

5 participants