Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass username to webchat #1353

Merged
merged 4 commits into from Mar 7, 2019

Conversation

Projects
None yet
5 participants
@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented Mar 6, 2019

fixes #1350

Fixed

  • [client] Pass along user name to webchat in PR #1353

@a-b-r-o-w-n a-b-r-o-w-n force-pushed the a-b-r-o-w-n:fix-missing-username branch from 02af3a7 to 964e658 Mar 7, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 7, 2019

Pull Request Test Coverage Report for Build 2166

  • 2 of 5 (40.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 54.956%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/ui/editor/emulator/parts/chat/chatContainer.ts 1 4 25.0%
Totals Coverage Status
Change from base Build 2165: -0.02%
Covered Lines: 4868
Relevant Lines: 8318

💛 - Coveralls

@cwhitten cwhitten merged commit eb85892 into Microsoft:master Mar 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@a-b-r-o-w-n a-b-r-o-w-n deleted the a-b-r-o-w-n:fix-missing-username branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.