Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typecheck before building app/main #1368

Merged
merged 2 commits into from Mar 11, 2019

Conversation

Projects
None yet
4 participants
@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented Mar 11, 2019

Also fixes a missing constant reference

Added

  • [main] Typecheck during build process #1368

Fixed

  • [main] Fix missing constant reference #1368

@a-b-r-o-w-n a-b-r-o-w-n force-pushed the a-b-r-o-w-n:typecheck-before-build branch from c2a6383 to 29288c6 Mar 11, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 11, 2019

Pull Request Test Coverage Report for Build 2212

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.99%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/main/src/main.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 2210: 0.0%
Covered Lines: 4873
Relevant Lines: 8321

💛 - Coveralls

@a-b-r-o-w-n a-b-r-o-w-n merged commit 684a72c into Microsoft:master Mar 11, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 54.99%
Details
license/cla All CLA requirements met.
Details

@a-b-r-o-w-n a-b-r-o-w-n deleted the a-b-r-o-w-n:typecheck-before-build branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.