This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[#1799] Fixed a screen reader issue with the dialog close button.#1845
Merged
Conversation
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum and
cwhitten
as code owners
tonyanziano
force-pushed
the
toanzian/acc-#1799
branch
from
211da6c to
1e20bc3
Compare
corinagum
approved these changes
Sep 6, 2019
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
Sorry, I thought I approved it yesterday
Contributor
Author
|
@corinagum you did, I just fixed conflicts :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1799
===
The narrator was reading out "Header level 2" when reading out the information for the dialog close button, but now it only reads out the information for the close button.