Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1799] Fixed a screen reader issue with the dialog close button. #1845

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Sep 5, 2019

#1799

===

The narrator was reading out "Header level 2" when reading out the information for the dialog close button, but now it only reads out the information for the close button.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 5, 2019

Coverage Status

Coverage remained the same at 65.767% when pulling 1e20bc3 on toanzian/acc-#1799 into 54aa2cc on master.

Copy link
Member

corinagum left a comment

Interesting bug.

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1799 branch from 211da6c to 1e20bc3 Sep 6, 2019
Copy link
Member

corinagum left a comment

Sorry, I thought I approved it yesterday

@tonyanziano

This comment has been minimized.

Copy link
Contributor Author

tonyanziano commented Sep 6, 2019

@corinagum you did, I just fixed conflicts :)

@tonyanziano tonyanziano merged commit de257ae into master Sep 6, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #78114 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1799 branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.