added LightGBM SWIG wrappers for macOS and updated docs#2002
Merged
guolinke merged 3 commits intolightgbm-org:masterfrom Feb 20, 2019
Merged
added LightGBM SWIG wrappers for macOS and updated docs#2002guolinke merged 3 commits intolightgbm-org:masterfrom
guolinke merged 3 commits intolightgbm-org:masterfrom
Conversation
StrikerRUS
reviewed
Feb 9, 2019
imatiach-msft
force-pushed
the
ilmat/add-swig-mac
branch
from
9b15372 to
06775c4
Compare
StrikerRUS
requested changes
Feb 12, 2019
Collaborator
StrikerRUS
left a comment
StrikerRUS
left a comment
There was a problem hiding this comment.
Please fix rst headers structure.
StrikerRUS
approved these changes
Feb 13, 2019
Collaborator
|
LGTM! Waiting for Apple Clang test. |
Contributor
Author
|
@StrikerRUS I verified that this works with Apple Clang instructions. Are there any other pending issues that need to be fixed? |
Collaborator
|
@imatiach-msft Glad to hear such great news! Thank you very much! Unfortunately, I have no permission to merge a PR with any failed check. Could you please wait till #2016 will be merged and update the branch (I'll notify you). |
Collaborator
|
@imatiach-msft We've repaired CI checks. Please update the branch. |
imatiach-msft
force-pushed
the
ilmat/add-swig-mac
branch
from
d4edd02 to
44b2c8e
Compare
Contributor
Author
|
@StrikerRUS done! |
Collaborator
|
@imatiach-msft Awesome! Thank you very much! I think this PR needs a second review before merging. Ping @chivee @guolinke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve Support for building Java Wrapper in OS X #1326