Cleanup temporary project output after running tests#38
Merged
sheetalkamat merged 1 commit intomasterfrom Jul 18, 2014
Merged
Conversation
| test-args.txt | ||
| ~*.docx | ||
| tests/baselines/local/* | ||
| tests/baselines/reference/projectOutput/ |
Contributor
There was a problem hiding this comment.
do we need this? The test may crash halfway through, leaving behind files we don't want. we probably don't want to check them into git accidently at that point.
Member
Author
There was a problem hiding this comment.
But shouldn't we be checking that tests run correctly before we do baseline-accept so runTests has to pass before you can baseline accept so I think this is fair rule to remove
Contributor
|
👍 |
sheetalkamat
added a commit
that referenced
this pull request
Jul 18, 2014
Cleanup temporary project output after running tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.