Breakpointspans using new compiler #594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates the fourslash breakpoints baseline to be more readable
…f last node of nodearaay
Contributor
|
/waiting. I'm not sure this is the appropriate strategy for breakpoints. It's much cleaner to just dive down and find the token the user is on, then walk up to the best statement node that contains that token, and set the span on that. Right now you're having to implement all the 'walk down' code yourself. You can see how Roslyn accomplishes this here: |
|
Changes Unknown when pulling b2b7d22 on breakpoints into * on master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Am still to do add no breakpoints in comments / empty line