Skip to content

Add DefaultProjectTypeGuid property for C# and Visual Basic#1607

Merged
rainersigwald merged 1 commit intodotnet:xplatfrom
dsplaisted:DefaultProjectTypeGuid
Feb 27, 2017
Merged

Add DefaultProjectTypeGuid property for C# and Visual Basic#1607
rainersigwald merged 1 commit intodotnet:xplatfrom
dsplaisted:DefaultProjectTypeGuid

Conversation

@dsplaisted
Copy link
Copy Markdown
Member

Fixes dotnet/sdk#522 and dotnet/cli#5131

The .NET CLI has a command to add projects to a solution. It needs to know what project type Guid to use in the solution for projects where it's not explicitly defined in the project file. This change adds a DefaultProjectTypeGuid property for C# and VB that it can use for this.

@jeffkl @rainersigwald @AndyGerlicher @jgoshi @davkean for review.

@KevinRansom @enricosada the F# targets should also add this property, I believe the F# value is {F2A71F9B-5D33-465A-A702-920D77279786}

Copy link
Copy Markdown
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it should just set <ProjectTypeGuids /> instead?

Copy link
Copy Markdown
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I notice some confusion about timeframes. dotnet/sdk#522 is set to 1.0 RTM, but @piotrpMSFT moved dotnet/cli#5131 out to 2.0.0 last week. Can we confirm that we need this for RTW (and it meets the bar)?

@jgoshi
Copy link
Copy Markdown

jgoshi commented Jan 25, 2017

What about F# default project type guid?

@dsplaisted
Copy link
Copy Markdown
Member Author

@jgoshi

What about F# default project type guid?

That needs to be added to the F# targets, which aren't in the MSBuild repo. I've tagged @KevinRansom and @enricosada about updating them.

@rainersigwald
Copy link
Copy Markdown
Member

@dotnet-bot test this please

@enricosada
Copy link
Copy Markdown

enricosada commented Jan 26, 2017

@jgoshi @dsplaisted added dotnet/netcorecli-fsc#63 to track adding the f# project guid to F# target file.
I'll do that next version of FSharp.NET.Sdk

@dsplaisted @jgoshi thx for ping. If there are other stuff like that, just add me as mention, i'll followup.
If i dont reply until the closing of the issue/PR, maybe i missed the notification, so please just open an issue in https://github.com/dotnet/netcorecli-fsc repo to track it. just a reference to PR/issue is enough, i'll check it.

@AndyGerlicher AndyGerlicher changed the base branch from vs15-rtw to xplat February 3, 2017 23:21
@AndyGerlicher
Copy link
Copy Markdown
Contributor

@dsplaisted did you still want this for Update 1? Or should I close?

@jgoshi
Copy link
Copy Markdown

jgoshi commented Feb 3, 2017

I think we still want this as soon as it makes sense right? So if possible to get that in to Update 1 I think that would be good? @piotrpMSFT can you confirm?

@AndyGerlicher
Copy link
Copy Markdown
Contributor

@dsplaisted I'm fine with this for Update 1. Can you resolve the conflicts please? It's probably because we renamed the root folders.

@AndyGerlicher
Copy link
Copy Markdown
Contributor

@dotnet-bot test Ubuntu16.04 Build for CoreCLR please

@dsplaisted
Copy link
Copy Markdown
Member Author

@AndyGerlicher Is it OK to go ahead and merge this?

@rainersigwald rainersigwald merged commit fa7be35 into dotnet:xplat Feb 27, 2017
@jgoshi
Copy link
Copy Markdown

jgoshi commented Mar 7, 2017

@dsplaisted @enricosada Do you know in which build this DefaultProjectTypeGuid is available for C#, VB, and F# projects? For the CLI in the master branch.

@enricosada
Copy link
Copy Markdown

@jgoshi for f# is defined in package reference FSharp.NET.Sdk so require a restore first.
will add that to Sdk attribute (so will work without restore) later

@jgoshi
Copy link
Copy Markdown

jgoshi commented Mar 7, 2017

@enricosada Do you have an ETA for when you'll add it to the Sdk? For this work I need to it work without requiring a call to restore first.

@enricosada
Copy link
Copy Markdown

@jgoshi any time, if you need it, but it's going in next cli/vs version (sdks are bundled with cli/vs).
So need to bump the fsharp.net.sdk inside dotnet/cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants