Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Default to C# project type guid#5703

Merged
livarcocc merged 2 commits intorel/1.0.0from
dev/jgoshi/dotnetAddDefaultProjectTypeGuid
Feb 15, 2017
Merged

Default to C# project type guid#5703
livarcocc merged 2 commits intorel/1.0.0from
dev/jgoshi/dotnetAddDefaultProjectTypeGuid

Conversation

@jgoshi
Copy link
Copy Markdown
Collaborator

@jgoshi jgoshi commented Feb 14, 2017

Fixes #5688

@piotrpMSFT @livarcocc @krwq @jonsequitur @eerhardt

The work to have the DefaultProjectTypeGuid isn't available yet. Here is the PR:
dotnet/msbuild#1607

And work also has to be done for F#. What we will eventually do in the CLI is to throw if there isn't an explicit ProjectTypeGuid or a DefaultProjectTypeGuid defined. But until the work for writing DefaultProjectTypeGuid goes in we need to burn in some default. This work changes the default to be the C# one. We will still be wrong in other cases (like for a VB project or F# project or any other type of project). But at least default to C# rather than CPS.

@livarcocc
Copy link
Copy Markdown

@srivatsn @dsplaisted

@livarcocc livarcocc added this to the 1.0.0-rtm milestone Feb 14, 2017
@TheRealPiotrP
Copy link
Copy Markdown

@nguerrera @dsplaisted @srivatsn can one of you review & approve?

Copy link
Copy Markdown
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I see update to the dotnet add tests. Were there no tests covering this Guid for the migrate scenario?

Also, just to be sure, it would be good to test opening the result of dotnet migrate and dotnet sln add (or whatever the syntax is) in VS and make sure that the issues described in #5665 are fixed.

@TheRealPiotrP
Copy link
Copy Markdown

@dsplaisted this change only covers the dotnet sln add scenario. Migration will be covered by #5665

@livarcocc
Copy link
Copy Markdown

No, migration actually shares this code. This will fix the migration issue as well. But the migration tests don't check that GUID explicitly. We rely on the sln add tests for that.

@jgoshi can correct me if I am wrong.

@jgoshi
Copy link
Copy Markdown
Collaborator Author

jgoshi commented Feb 15, 2017

@livarcocc is correct. Whenever migration needs to add a project to the sln file it calls dotnet sln add.

@jgoshi
Copy link
Copy Markdown
Collaborator Author

jgoshi commented Feb 15, 2017

I also manually tried the scenario specified by
https://github.com/dotnet/cli/issues/5665

And this fixes it.

@livarcocc livarcocc merged commit 860c451 into rel/1.0.0 Feb 15, 2017
@livarcocc livarcocc deleted the dev/jgoshi/dotnetAddDefaultProjectTypeGuid branch February 15, 2017 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants