New emmet: css property width expands to `widows`??

[jens1o]

• VSCode Version: Code - Insiders 1.14.0-insider (73015a5, 2017-06-16T05:13:31.107Z)
• OS Version: Windows_NT ia32 10.0.15063
• Extensions:

Extension	Author (truncated)	Version
path-intellisense	chr	1.4.2
gitlens	eam	4.1.2
LogFileHighlighter	emi	1.1.1
vscode-reveal	evi	0.0.9
php-debug	fel	1.10.0
php-intellisense	fel	1.4.1
auto-close-tag	for	0.4.2
gc-excelviewer	Gra	1.1.15
GitHubIssues	Hoo	0.1.2
composer	ika	0.5.0
smarty	imp	0.2.0
json-to-ts	Mar	1.4.3
vscode-apache	mrm	1.1.1
cpptools	ms-	0.11.4
php-docblocker	nei	1.2.0
vscode-versionlens	pfl	0.19.0
vscode-statusbar-json-path	ric	1.0.7
vscode-icons	rob	7.9.0
sharecode	Rol	0.4.1
code-spell-checker	str	1.2.0
vscode-todo-highlight	way	0.5.5
highlight-trailing-white-spaces	yba	0.0.2

(1 theme extensions excluded)

---

have fun.

// cc @ramya-rao-a

[ramya-rao-a]

I am having a deja vu :)

w gives width
wi and anything further gives widows

This is coming from the way snippets are defined in https://github.com/emmetio/snippets/blob/master/css.json

@sergeche thoughts?

cc @sergeche

[druellan]

I'm starting to get similar results with other properties:

the default hint for font-family is font: fantasy; which is a very loose association and ruins the hinting system

[jens1o]

wi and anything further gives widows

but then I would expect that the label updates too...

[sergeche]

Not sure what expected behaviour should be if you type full property name and try to expand it as Emmet abbreviation. CSS itself has too much clashing properties/abbreviations. The goal of shortcuts is to provide shorthands for most commonly used properties. Users should learn these shortcuts by typing first letters and seeing autocomplete popup with available options. If the full property names will be considered in abbreviation resolving, they will collide with shorthands, especially ones with embedded shorthand values, like m-a for margin: auto.

So the ultimate goal is to provide matched snippets and expanded abbreviation with previews

[ramya-rao-a]

Another example:

User expectation would be to match "padding"

@sergeche In this case the only match between "padd" and the suggested shorthand "pgba" is the first letter "p". Aren't we being too eager while matching here?

[vvs]

Indeed, this eager matching to the Emmet shorthands severely breaks (this) user expectations.

When I have almost complete property name, like "borde", "paddin", "margi", etc, I would assume that VS Code does the right thing and expands these widely-used properties. Instead, I get completely random and unrelated (at least that's how it looks) suggestions from Emmet.

My expectation would be that Emmet's suggestions should not always be the number 1 in the suggestion list, and sometimes they should be ranked lower as compared to the almost fully-matched widely used properties.

Suggesting "pgba" shorthand as a top choice for "paddin" is just wrong (at least, to me).