php: Emmet abbreviations with class operator dont show up in suggestions unless php.suggest.basic is disabled

[ramya-rao-a]

In a php file, below abbreviations that have the class operator dont show up in suggestions unless php.suggest.basic is disabled

• .hello
• ul.hello

[jens1o]

Well, most of the time the users have disabled this option, because there are extensions which provide better language support. So this doesn't affect that many users.

[ramya-rao-a]

@jens1o That's good to know, but I'd still like to get to the root cause of this issue.

[roblourens]

@jrieken We debugged a little and this looks like an issue with suggestions in general -

There are two suggestion providers registered, PHP and Emmet. Both are triggered on .. When . is pressed, Emmet returns nothing, and PHP returns a complete list. When more characters are typed, the completion providers aren't called again, because the completion model is only looking at existing completion items to determine whether the full list is complete. Emmet returned an incomplete result, but since the list was empty, that isn't taken into account by CompletionModel._createCachedState.

If we change Emmet to always return a dummy result, this doesn't repro. Maybe it's unexpected for a completion provider to return more suggestions once more characters have been typed - that's the situation here because it returns nothing for . but results for .foo

[jrieken]

Yeah, I'd say this is a dupe of #13735. I am not decided one what to do because an empty, but incomplete result set sound wrong to me. With that an extension can hijack the whole completion logic...

[jrieken]

closing as dupe of #13735. @ramya-rao-a let me know if you need this for September