New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable click and open mailto links in Markdown preview #36795

Merged
merged 2 commits into from Oct 25, 2017

Conversation

Projects
None yet
2 participants
@misoguy
Contributor

misoguy commented Oct 24, 2017

Fixes #36601

@mjbvz mjbvz self-assigned this Oct 24, 2017

@mjbvz

This comment has been minimized.

Show comment
Hide comment
@mjbvz

mjbvz Oct 24, 2017

Contributor

Change looks good to me. Thanks for looking into this. Can you just please quickly resolve the merge conflict

Contributor

mjbvz commented Oct 24, 2017

Change looks good to me. Thanks for looking into this. Can you just please quickly resolve the merge conflict

@misoguy

This comment has been minimized.

Show comment
Hide comment
@misoguy

misoguy Oct 25, 2017

Contributor

@mjbvz I have resolved the merge conflict.
However, as I was doing so I found a bug(?) in the code which is causing the merge conflict.
newTab is returning null here and causing the editor not to open a new window when a link is clicked.
I think it'll be better for me to make a new pull request regarding this bug.

Contributor

misoguy commented Oct 25, 2017

@mjbvz I have resolved the merge conflict.
However, as I was doing so I found a bug(?) in the code which is causing the merge conflict.
newTab is returning null here and causing the editor not to open a new window when a link is clicked.
I think it'll be better for me to make a new pull request regarding this bug.

@mjbvz mjbvz added this to the October 2017 milestone Oct 25, 2017

@mjbvz mjbvz merged commit ca8bb6a into Microsoft:master Oct 25, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@mjbvz

This comment has been minimized.

Show comment
Hide comment
@mjbvz

mjbvz Oct 25, 2017

Contributor

Thanks! This should be in the next insiders build and in VSCode 1.18

Contributor

mjbvz commented Oct 25, 2017

Thanks! This should be in the next insiders build and in VSCode 1.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment