Skip to content

Enable click and open mailto links in Markdown preview #36795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjbvz merged 2 commits into from
Oct 25, 2017
Merged

Enable click and open mailto links in Markdown preview #36795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4cd689
Enable click and open mailto links in Markdown preview
misoguy Oct 24, 2017
e79a4e0
Merge branch 'master' into fix#36601
misoguy Oct 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/vs/base/common/network.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,7 @@ export namespace Schemas {

export const file: string = 'file';

export const mailto: string = 'mailto';

export const untitled: string = 'untitled';
}
6 changes: 3 additions & 3 deletions src/vs/platform/opener/browser/openerService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ export class OpenerService implements IOpenerService {

const { scheme, path, query, fragment } = resource;
let promise: TPromise<any>;
if (scheme === Schemas.http || scheme === Schemas.https) {
// open http
dom.windowOpenNoOpener(resource.toString(true));

if (scheme === Schemas.http || scheme === Schemas.https || scheme === Schemas.mailto) {
// open http or default mail application
dom.windowOpenNoOpener(resource.toString(true));
} else if (scheme === 'command' && CommandsRegistry.getCommand(path)) {
// execute as command
let args: any = [];
Expand Down