New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #46123 : Remove absolute path for python #56943

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
2 participants
@jats22
Contributor

jats22 commented Aug 21, 2018

Fixes #46123

@rebornix rebornix requested a review from joaomoreno Aug 21, 2018

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Aug 22, 2018

Member

@jats22 Did you confirm that that snippet of python code runs on any python version 2 and 3?

Member

joaomoreno commented Aug 22, 2018

@jats22 Did you confirm that that snippet of python code runs on any python version 2 and 3?

@joaomoreno joaomoreno added this to the Backlog milestone Aug 22, 2018

@jats22

This comment has been minimized.

Show comment
Hide comment
@jats22

jats22 Aug 22, 2018

Contributor

@joaomoreno I tested that line of python code in version 2.7 & 3 and got the same result. And as per https://docs.python.org/3/whatsnew/3.0.html I understand that the print as a function is backpropagated into 2.6 as well.

pythonout

Am I missing something?
Also I am not sure as though how this script is used in the project however. Any pointers?

Contributor

jats22 commented Aug 22, 2018

@joaomoreno I tested that line of python code in version 2.7 & 3 and got the same result. And as per https://docs.python.org/3/whatsnew/3.0.html I understand that the print as a function is backpropagated into 2.6 as well.

pythonout

Am I missing something?
Also I am not sure as though how this script is used in the project however. Any pointers?

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Aug 23, 2018

Member

On macOS, there's a global command Shell Command: Install 'code' command in PATH. This will allow users to simply run code globally. This shell script is what runs in that scenario.

Member

joaomoreno commented Aug 23, 2018

On macOS, there's a global command Shell Command: Install 'code' command in PATH. This will allow users to simply run code globally. This shell script is what runs in that scenario.

@jats22

This comment has been minimized.

Show comment
Hide comment
@jats22

jats22 Aug 26, 2018

Contributor

Ahh. I see. Thanks!

Contributor

jats22 commented Aug 26, 2018

Ahh. I see. Thanks!

@joaomoreno joaomoreno modified the milestones: Backlog, September 2018 Sep 13, 2018

@joaomoreno joaomoreno merged commit a5c6208 into Microsoft:master Sep 13, 2018

2 checks passed

VSTS: VS Code 20180821.61 succeeded
Details
license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Sep 13, 2018

Member

Thanks! 🍻

Member

joaomoreno commented Sep 13, 2018

Thanks! 🍻

@jats22 jats22 deleted the jats22:46123 branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment