New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #57222 - improve no user.email/user.name config error message #58174

Merged
merged 3 commits into from Sep 13, 2018

Conversation

Projects
None yet
5 participants
@Git-Lior

Git-Lior commented Sep 7, 2018

The new message looks like this:

image

Tell me if anything can be improved. Thanks!

@dzienisz

This comment has been minimized.

Show comment
Hide comment
@dzienisz

dzienisz Sep 7, 2018

Is there a possibility to show current email and name config?

dzienisz commented Sep 7, 2018

Is there a possibility to show current email and name config?

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Sep 7, 2018

CLA assistant check
All CLA requirements met.

msftclas commented Sep 7, 2018

CLA assistant check
All CLA requirements met.

@Git-Lior

This comment has been minimized.

Show comment
Hide comment
@Git-Lior

Git-Lior Sep 7, 2018

Now the error message looks like this:

image

@dzienisz is this better?

Git-Lior commented Sep 7, 2018

Now the error message looks like this:

image

@dzienisz is this better?

@dzienisz

This comment has been minimized.

Show comment
Hide comment
@dzienisz

dzienisz Sep 7, 2018

@Git-Lior I think so. Thanks!

dzienisz commented Sep 7, 2018

@Git-Lior I think so. Thanks!

@mc10

This comment has been minimized.

Show comment
Hide comment
@mc10

mc10 Sep 8, 2018

Contributor

For consistency, maybe flip the two current lines so email comes first and name comes second?

Contributor

mc10 commented Sep 8, 2018

For consistency, maybe flip the two current lines so email comes first and name comes second?

@Git-Lior

This comment has been minimized.

Show comment
Hide comment
@Git-Lior

Git-Lior Sep 8, 2018

@mc10 you're correct, done 👍

Git-Lior commented Sep 8, 2018

@mc10 you're correct, done 👍

@joaomoreno joaomoreno added this to the Backlog milestone Sep 10, 2018

@joaomoreno joaomoreno added the git label Sep 10, 2018

@joaomoreno joaomoreno merged commit 8d147f3 into Microsoft:master Sep 13, 2018

2 checks passed

VS Code #20180908.15 succeeded with issues
Details
license/cla All CLA requirements met.
Details

@joaomoreno joaomoreno modified the milestones: Backlog, September 2018 Sep 13, 2018

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Sep 13, 2018

Member

Thanks! 🍻

Member

joaomoreno commented Sep 13, 2018

Thanks! 🍻

@Git-Lior Git-Lior deleted the Git-Lior:git-missing-user-info branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment