New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to make the EH debugging to work when live share proxy the debug adapter #58227

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@rodrigovaras

rodrigovaras commented Sep 7, 2018

A recent change on vscode stop 'injecting' the '__sessionI' property for all resolved configurations except the EH debugging type. vscode will always see the type as 'vslsShare' insted of 'extensionHost' type.
The changes will identify such cases and inspect the debug configuration looking for the proper debug type.

Rodrigo Varas
Fixes to allow identify the proper debug type when a live share debug…
… configuration was resolved by the extension
@rodrigovaras

This comment has been minimized.

Show comment
Hide comment
@rodrigovaras

rodrigovaras Sep 7, 2018

@weinand, can you take a look to this?

rodrigovaras commented Sep 7, 2018

@weinand, can you take a look to this?

@weinand

This comment has been minimized.

Show comment
Hide comment
@weinand

weinand Sep 7, 2018

Member

Thanks for the PR.
I have centralized the EH check into one place.

Member

weinand commented Sep 7, 2018

Thanks for the PR.
I have centralized the EH check into one place.

@weinand weinand closed this Sep 7, 2018

@weinand weinand added this to the September 2018 milestone Sep 7, 2018

@weinand weinand self-assigned this Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment