New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Electron to 2.0.9 #58382

Merged
merged 1 commit into from Sep 11, 2018

Conversation

Projects
None yet
3 participants
@mfonville
Contributor

mfonville commented Sep 10, 2018

As described in #57457

Fixes the glibc 2.28 problem, includes the other fixes that @bpasero was waiting for

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Sep 10, 2018

CLA assistant check
All CLA requirements met.

msftclas commented Sep 10, 2018

CLA assistant check
All CLA requirements met.

@bpasero

There is also a reference in the package.json of the smoke test (just search for 2.0.7)

@bpasero bpasero added this to the September 2018 milestone Sep 11, 2018

@bpasero bpasero self-assigned this Sep 11, 2018

@mfonville

This comment has been minimized.

Show comment
Hide comment
@mfonville

mfonville Sep 11, 2018

Contributor

Thanks, I amended the commit for the PR

Contributor

mfonville commented Sep 11, 2018

Thanks, I amended the commit for the PR

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Sep 11, 2018

Member

@mfonville thanks, I think you need to run a yarn install in the smoke test to get the yarn.lock file also updated.

Member

bpasero commented Sep 11, 2018

@mfonville thanks, I think you need to run a yarn install in the smoke test to get the yarn.lock file also updated.

@mfonville

This comment has been minimized.

Show comment
Hide comment
@mfonville

mfonville Sep 11, 2018

Contributor

Ok, I also updated the lock file

Contributor

mfonville commented Sep 11, 2018

Ok, I also updated the lock file

@bpasero bpasero merged commit 2ba2fa5 into Microsoft:master Sep 11, 2018

1 of 2 checks passed

VS Code #20180911.21 failed
Details
license/cla All CLA requirements met.
Details
@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Sep 11, 2018

Member

Thanks!

Member

bpasero commented Sep 11, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment