New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing access keys (mnemonics) for menu items #58412

Merged
merged 2 commits into from Sep 11, 2018

Conversation

Projects
None yet
4 participants
@rik-smeets
Contributor

rik-smeets commented Sep 11, 2018

Add missing access keys (mnemonics) for:

  • Update menu items (i.e. Restart to Update etc.)
  • Add Configuration
  • Enable All Breakpoints
  • Auto Save

When I was looking at the improvements done by @sbatten with regards to #54349, I noticed some access keys were missing. I added those in this pull request.

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Sep 11, 2018

CLA assistant check
All CLA requirements met.

msftclas commented Sep 11, 2018

CLA assistant check
All CLA requirements met.

Add missing access keys (mnemonics) for Update menu items, Add Config…
…uration, Enable All Breakpoints and Auto Save

@sbatten sbatten added this to the September 2018 milestone Sep 11, 2018

@sbatten sbatten self-requested a review Sep 11, 2018

@sbatten

This comment has been minimized.

Show comment
Hide comment
@sbatten

sbatten Sep 11, 2018

Member

Thanks @rik-smeets, I've added the mnemonics to the native menu system for consistency.

Member

sbatten commented Sep 11, 2018

Thanks @rik-smeets, I've added the mnemonics to the native menu system for consistency.

@sbatten sbatten merged commit 7bca3fb into Microsoft:master Sep 11, 2018

1 of 2 checks passed

VS Code in progress
Details
license/cla All CLA requirements met.
Details

@rik-smeets rik-smeets deleted the rik-smeets:add-missing-access-keys branch Sep 11, 2018

@joaosamouco

This comment has been minimized.

Show comment
Hide comment
@joaosamouco

joaosamouco Sep 13, 2018

I believe this change is causing issues on the most recent Code Insiders (Version 1.28.0-insider (1.28.0-insider).

screen shot 2018-09-13 at 13 00 46

As you can see, some & is being displayed on Check for Updates option. This is also occuring in other Menu Options.

joaosamouco commented Sep 13, 2018

I believe this change is causing issues on the most recent Code Insiders (Version 1.28.0-insider (1.28.0-insider).

screen shot 2018-09-13 at 13 00 46

As you can see, some & is being displayed on Check for Updates option. This is also occuring in other Menu Options.

@joaosamouco joaosamouco referenced this pull request Sep 13, 2018

Closed

Typo in menu? #58603

@rik-smeets

This comment has been minimized.

Show comment
Hide comment
@rik-smeets

rik-smeets Sep 13, 2018

Contributor

@joaosamouco I think so too, see #58603 for my quick analysis.

Contributor

rik-smeets commented Sep 13, 2018

@joaosamouco I think so too, see #58603 for my quick analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment