Allow Developers to Manually Request Permissions when using CameraView, FileSaver, FolderPicker and SpeechToText#607
Conversation
…w, FileSaver, FolderPicker and SpeechToText
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 86932e6: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit a6d2eb8: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
@bijington @jfversluis could you please review |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit fc4d096: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Pull request overview
This pull request adds documentation for manual permission requests required when using CameraView, FileSaver, FolderPicker, and SpeechToText features. The changes emphasize that developers must explicitly request necessary permissions before using these components.
Changes:
- Added permission request documentation and code examples for CameraView (camera and microphone permissions)
- Added permission request documentation for FileSaver (storage read/write permissions)
- Added permission request documentation for FolderPicker (storage read permissions)
- Added permission request documentation for SpeechToText (microphone and speech recognition permissions)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docs/maui/views/camera-view.md | Added microphone permission requirements for video recording and manual permission request examples |
| docs/maui/essentials/speech-to-text.md | Restructured to add request permissions section with examples for microphone and speech-to-text permissions |
| docs/maui/essentials/folder-picker.md | Restructured to add request permissions section with storage read permission example |
| docs/maui/essentials/file-saver.md | Restructured to add request permissions section with storage read/write permission examples |
Comments suppressed due to low confidence (1)
docs/maui/essentials/folder-picker.md:1
- Similar to CameraView, the permission result is captured but not checked. Consider adding an example that shows how to verify the permission was granted before proceeding with folder picking operations.
---
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Developers must manually request Permissions.Camera and/or Permissions.Microphone: | ||
|
|
||
| ```csharp | ||
| var cameraPermissionsRequest = await Permissions.RequestAsync<Permissions.Camera>(); |
There was a problem hiding this comment.
The variable captures the result of RequestAsync but the returned value is not used or checked. Consider adding guidance about checking the permission status, similar to the pattern shown in the SpeechToText example where the result is checked against PermissionStatus.Granted.
There was a problem hiding this comment.
@copilot commit changes based on this feedback
| In case you plan to record video, request Microphone permissions: | ||
|
|
||
| ```csharp | ||
| var microphonePermissionsRequest = await Permissions.RequestAsync<Permissions.Microphone>(); |
There was a problem hiding this comment.
The variable captures the result of RequestAsync but the returned value is not used or checked. Consider adding guidance about checking the permission status or showing a complete example that demonstrates how to verify permissions were granted.
There was a problem hiding this comment.
@copilot commit changes based on this feedback
bijington
left a comment
bijington
left a comment
There was a problem hiding this comment.
In general this looks good but I think the copilot suggestions are worth actioning
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 8dc199a: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit e0e02e1: ✅ Validation status: passed
For more details, please refer to the build report. |
2 participants
No description provided.