Skip to content

Add tip about Popup base class inheritance to XAML popup docs#627

Merged
jfversluis merged 2 commits intomainfrom
copilot/fix-building-popup-xaml-issue
Mar 16, 2026
Merged

Add tip about Popup base class inheritance to XAML popup docs#627
jfversluis merged 2 commits intomainfrom
copilot/fix-building-popup-xaml-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 16, 2026

The "Building a Popup in XAML" section tells users to create a ContentView but doesn't mention that advanced scenarios require inheriting from CommunityToolkit.Maui.Views.Popup or Popup<T> in the code-behind — leading to runtime errors for users following the docs.

  • Added a [!TIP] callout after the XAML example linking to the Popup - Returning a result page, which demonstrates the required inheritance pattern
Original prompt

This section details on the original issue you should resolve

<issue_title>"Building a Popup in XAML" Missing important information</issue_title>
<issue_description>### Type of issue

Missing information

Description

[Enter feedback here]You didn't mention that if you choose to use a xaml as a popup you need to make sure the xaml.cs inherits from CommunityTookKit.Maui.Views.PopUp. This will throw an error when you call it. I know that the information is available in the docs but if users need to get the concept first, and are coming here to try it for the first time, it can be frustrating.

Page URL

https://learn.microsoft.com/en-us/dotnet/communitytoolkit/maui/views/popup

Content source URL

https://github.com/MicrosoftDocs/CommunityToolkit/blob/main/docs/maui/views/Popup.md

Document Version Independent Id

c6126a74-78aa-2c4f-ce92-2cda527ca9fd

Platform Id

6de6bfab-e40a-2d12-6b54-92ba9ca262d2

Article author

@bijington

Metadata

  • ID: c6126a74-78aa-2c4f-ce92-2cda527ca9fd
  • PlatformId: 6de6bfab-e40a-2d12-6b54-92ba9ca262d2
  • Service: dotnet-communitytoolkit
  • Sub-service: dotnet-maui-community-toolkit</issue_description>

Comments on the Issue (you are @copilot in this section)

@bijington Would it be better if we link to this example that does highlight that detail?

https://learn.microsoft.com/en-us/dotnet/communitytoolkit/maui/views/popup/popup-result</comment_new>


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@learn-build-service-prod
Copy link
Copy Markdown

Learn Build status updates of commit 1a22523:

⚠️ Validation status: warnings

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>
@jfversluis jfversluis added the maui The .NET MAUI Community Toolkit label Mar 16, 2026
@learn-build-service-prod
Copy link
Copy Markdown

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link
Copy Markdown

Learn Build status updates of commit 260ea62:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/views/Popup.md ✅Succeeded View

For more details, please refer to the build report.

Copilot AI changed the title [WIP] Fix missing information in building a popup in XAML Add tip about Popup base class inheritance to XAML popup docs Mar 16, 2026
Copilot AI requested a review from jfversluis March 16, 2026 08:38
@jfversluis jfversluis marked this pull request as ready for review March 16, 2026 08:46
@jfversluis jfversluis merged commit 79c2a2b into main Mar 16, 2026
3 checks passed
@jfversluis jfversluis deleted the copilot/fix-building-popup-xaml-issue branch March 16, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maui The .NET MAUI Community Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Building a Popup in XAML" Missing important information

3 participants