Skip to content

Add missing comparsion operators, BNF grammar fixes, markdown formatting#11044

Merged
sdwheeler merged 4 commits intoMicrosoftDocs:mainfrom
glenn-slayden:patch-1
Apr 23, 2024
Merged

Add missing comparsion operators, BNF grammar fixes, markdown formatting#11044
sdwheeler merged 4 commits intoMicrosoftDocs:mainfrom
glenn-slayden:patch-1

Conversation

@glenn-slayden
Copy link
Copy Markdown
Contributor

PR Summary

  1. The BNF grammar is totally broken. This moves forward with a few fixes.
  2. Many of the comparison operators were missing
  3. Added a few missingSyntax: sections

Please consider this PR on an 'as-is' basis; I believe the changes are a positive contribution which you can use or modify any way you like without my further participation.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

@learn-build-service-prod

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown

Expectations

Thanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it.

To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details.

The docs team begins to review your PR if you request them to or if your PR meets these conditions:

  • It is not a draft PR.
  • It does not have a WIP prefix in the title.
  • It passes validation and build steps.
  • It does not have any merge conflicts.
  • You have checked every box in the PR Checklist, indicating you have completed all required steps and marked your PR as Ready to Merge.

You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge.

While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST).

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 7be4eb5:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/lang-spec/chapter-02.md ✅Succeeded View (>=powershell-5.1)
reference/docs-conceptual/lang-spec/chapter-07.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

For any questions, please:

@sdwheeler sdwheeler merged commit 1807cd8 into MicrosoftDocs:main Apr 23, 2024
@Taojunshen Taojunshen mentioned this pull request Apr 23, 2024
4 tasks
@glenn-slayden
Copy link
Copy Markdown
Contributor Author

Hey Sean,

I know I said I "wasn't going to come back..." but WOW you worked hard! on that little project. I know how long it must have taken you -- because I was paining over the few changes I did try to make.

I felt like it can be hard to know how far to push further on into an uncertain task that, to me, seemed doomed to fail... but you sure showed me... Great work!

Glenn

@glenn-slayden glenn-slayden deleted the patch-1 branch April 24, 2024 18:18
@sdwheeler
Copy link
Copy Markdown
Collaborator

I felt like it can be hard to know how far to push further on into an uncertain task that, to me, seemed doomed to fail... but you sure showed me... Great work!

Thanks. I saw what you were trying to do. There were issues with some of the changes, but you were heading in the right direction.

I usually don't take updates to the Language Reference because it was published here from the original source Word document as historical information. However, there is value and fixing some of the flaws from the original document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants