Fix Example for Get-Member -InputObject#3373
Merged
sdwheeler merged 11 commits intoMicrosoftDocs:stagingfrom Dec 3, 2018
Merged
Fix Example for Get-Member -InputObject#3373sdwheeler merged 11 commits intoMicrosoftDocs:stagingfrom
sdwheeler merged 11 commits intoMicrosoftDocs:stagingfrom
Conversation
* Fix syntax error * Fix command sequence and commands used * Fix unclear example sequence Thanks to [Ramon TAN](https://powershell.org/forums/topic/get-member-examples-different-results-on-my-pc/#post-127867) for stumbling across this in confusion!
Contributor
|
Update v5 document with change
update v5.0 document with change
Update v4.0 document
Update v3.0 document
Contributor
Author
|
Not sure what all that's about, I only changed a few files here. 😄 Anyway, finished updating all the versions of the help. All versions had similar logical issues with the code example; I'm surprised it's been there in some form or another since v3.0 with nobody pointing out that the code doesn't work in that section! |
Contributor
|
sdwheeler
requested changes
Dec 3, 2018
| ### Example 6: Get members for an array | ||
| ``` | ||
| PS C:\> $A = Get-Member - InputObject @(1) | ||
| PS C:\> $A = @(1) |
Collaborator
There was a problem hiding this comment.
If you are going to include the PowerShell prompt in examples, please use "PS>" for the prompt. See https://github.com/PowerShell/PowerShell-Docs/blob/staging/contributing/5-FORMATTING-CODE.md#simple-illustration-example
Please make this change to each version of the file.
Contributor
Author
There was a problem hiding this comment.
That's usually my preference, but I opted to retain the original format of the example. I'll change these ones for now. 😄
Collaborator
|
@vexx32 Thank you for your contribution. I have a minor change request. See my review comment. Please apply that same change to all versions. |
Trim prompt from examples in 3.0 file
Trim path from prompts in 4.0 file
Trim paths from prompts in 5.0 document
Trim Paths from prompts in 5.1 file
2nd pass for 5.0 file
Contributor
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Collaborator
|
@vexx32 Thanks. I know that it was inconsistent across the versions. It was a style change we made a while back and we are trying to use the new style whenever we touch an article. |
Trim paths from prompts in v6 file
sdwheeler
approved these changes
Dec 3, 2018
Contributor
Author
|
Think that should be everything. Noted a couple of other examples had some minor typographical issues around the prompts as well, so did a full pass on the examples in all the files. 😄 |
Contributor
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Contributor
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
v-alje
pushed a commit
that referenced
this pull request
Dec 11, 2018
* Fix Example for Get-Member -InputObject * Fix syntax error * Fix command sequence and commands used * Fix unclear example sequence Thanks to [Ramon TAN](https://powershell.org/forums/topic/get-member-examples-different-results-on-my-pc/#post-127867) for stumbling across this in confusion! * Update Get-Member.md Update v5 document with change * Update Get-Member.md update v5.0 document with change * Update Get-Member.md Update v4.0 document * Update Get-Member.md Update v3.0 document * Update Get-Member.md Trim prompt from examples in 3.0 file * Update Get-Member.md Trim path from prompts in 4.0 file * Update Get-Member.md Trim paths from prompts in 5.0 document * Update Get-Member.md Trim Paths from prompts in 5.1 file * Update Get-Member.md 2nd pass for 5.0 file * Update Get-Member.md Trim paths from prompts in v6 file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to Ramon TAN for stumbling across this in confusion!
Version(s) of document impacted
Reason(s) for not updating all version of documents