Skip to content

Update New-IseSnippet.md#794

Merged
1 commit merged intoMicrosoftDocs:stagingfrom
alexandair:patch-16
Nov 14, 2016
Merged

Update New-IseSnippet.md#794
1 commit merged intoMicrosoftDocs:stagingfrom
alexandair:patch-16

Conversation

@alexandair
Copy link
Copy Markdown
Contributor

Fix metadata and casing.

Fix metadata and casing.
@saldana
Copy link
Copy Markdown
Contributor

saldana commented Nov 12, 2016

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/ISE/New-IseSnippet.md ✅Succeeded Details

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@vors
Copy link
Copy Markdown
Contributor

vors commented Nov 12, 2016

For the metadata part, I think it's better to do it once for all files.
The root of the problem is in the fact that GitHub is not friendly to UTF-8 with BOM encoding. It doesn't understand the BOM correctly when it renders it and that's what makes metadata messed up.
I made an attempt in #788 , but found few problem with re-encoding.

@andschwa used iconv when we had the same problem in https://github.com/PowerShell/PowerShell for source files.

@alexandair
Copy link
Copy Markdown
Contributor Author

@vors I agree that it's better to do it once for all files. I've just wanted to check if it occurs multiple times and then I fixed it for a few help topics just as I was fixing other things anyway. :)
I'll leave you or someone else from PS team to fix all metadata.
Btw, great work!

@vors
Copy link
Copy Markdown
Contributor

vors commented Nov 13, 2016

I sent #797 with re-encoding all the files under references/

@alexandair
Copy link
Copy Markdown
Contributor Author

@vors Excellent. Could you merge my PRs before you merge yours to avoid conflicts because I've changed some other things not just metadata?

@vors
Copy link
Copy Markdown
Contributor

vors commented Nov 13, 2016

I don't have permissions to merge PRs in this repo.

@alexandair
Copy link
Copy Markdown
Contributor Author

OK, I'll try to find out who can.

@kiazhi
Copy link
Copy Markdown
Contributor

kiazhi commented Nov 13, 2016

@alexandair, I think @HemantMahawar can help you on that.

@alexandair
Copy link
Copy Markdown
Contributor Author

@kiazhi I've just sent @HemantMahawar an email. :)

@ghost ghost merged commit fc447a9 into MicrosoftDocs:staging Nov 14, 2016
@alexandair alexandair deleted the patch-16 branch November 19, 2016 01:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants