Add test cases for the Wizard!#509
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new xUnit-based test project to the WDAC Policy Wizard solution and adjusts core policy/validation logic to support the tests.
Changes:
- Added
WDAC-Wizard.Testsproject (xUnit + coverlet) and included it in the solution. - Updated
WDAC_Policy.UpdateVersionrollover logic and added a null-guard inCOM.IsValidRule. - Exposed internals to the test assembly via
InternalsVisibleTo.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| WDAC-Policy-Wizard/app/src/Policy.cs | Changes version increment/rollover logic and adds COM GUID null handling. |
| WDAC-Policy-Wizard/app/WDAC Wizard.sln | Adds the new test project to the solution. |
| WDAC-Policy-Wizard/app/Properties/AssemblyInfo.cs | Adds InternalsVisibleTo for the test assembly. |
| WDAC-Policy-Wizard/app/.claude/settings.local.json | Adds local Claude tool permissions file. |
| WDAC-Policy-Wizard/WDAC-Wizard.Tests/WDAC-Wizard.Tests.csproj | Introduces the new .NET test project and dependencies. |
| WDAC-Policy-Wizard/WDAC-Wizard.Tests/README.md | Documents test suite scope and how to run tests. |
| WDAC-Policy-Wizard/WDAC-Wizard.Tests/PolicyTests.cs | Adds tests for policy logic and supporting classes. |
| WDAC-Policy-Wizard/WDAC-Wizard.Tests/LoggerTests.cs | Adds tests for the Logger singleton output/files. |
| WDAC-Policy-Wizard/WDAC-Wizard.Tests/HelperTests.cs | Adds tests for helper/validation utilities and EKU encoding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Initial plan * Fix stale comments in UpdateVersion test cases to match actual implementation Co-authored-by: jgeurten <23045608+jgeurten@users.noreply.github.com> Agent-Logs-Url: https://github.com/MicrosoftDocs/WDAC-Toolkit/sessions/6c0a8b8c-31b6-4779-b9a7-baa99617b602 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jgeurten <23045608+jgeurten@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 90+ tests to the Wizard (about time)!
or in the UI:
Test Explorer Output:
Test explorer will show the result for each test -