Skip to content

Conversation

@elainajones
Copy link

Adds missing command to install azure.storage.blob python package as referenced in the code examples. Without this, users may not know proper install steps. Fixes sequence of numbered bullets.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit b947892:

💡 Validation status: suggestions

File Status Preview URL Details
articles/python/sdk/authentication-azure-hosted-apps.md 💡Suggestion Details
articles/python/sdk/authentication-local-development-dev-accounts.md 💡Suggestion Details
articles/python/sdk/authentication-local-development-service-principal.md 💡Suggestion Details
articles/python/sdk/authentication-on-premises-apps.md 💡Suggestion Details
articles/python/sdk/authentication-overview.md 💡Suggestion Details

articles/python/sdk/authentication-azure-hosted-apps.md

  • Line 120, Column 244: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/storage/common/storage-account-overview' will be broken in isolated environments. Replace with a relative link.

articles/python/sdk/authentication-local-development-dev-accounts.md

  • Line 162, Column 667: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/storage/common/storage-account-overview' will be broken in isolated environments. Replace with a relative link.

articles/python/sdk/authentication-local-development-service-principal.md

  • Line 205, Column 517: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/storage/common/storage-account-overview' will be broken in isolated environments. Replace with a relative link.

articles/python/sdk/authentication-on-premises-apps.md

  • Line 130, Column 259: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/storage/common/storage-account-overview' will be broken in isolated environments. Replace with a relative link.

articles/python/sdk/authentication-overview.md

  • Line 64, Column 321: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/storage/common/storage-account-overview' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@elainajones
Copy link
Author

@microsoft-github-policy-service agree

@prmerger-automator
Copy link
Contributor

@elainajones : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Adds missing command to install azure.storage.blob python package
as referenced in the code examples. Without this, users may not
know proper install steps. Fixes sequence of numbered bullets.
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 62c6515:

💡 Validation status: suggestions

File Status Preview URL Details
articles/python/sdk/authentication-azure-hosted-apps.md 💡Suggestion Details
articles/python/sdk/authentication-local-development-dev-accounts.md 💡Suggestion Details
articles/python/sdk/authentication-local-development-service-principal.md 💡Suggestion Details
articles/python/sdk/authentication-on-premises-apps.md 💡Suggestion Details
articles/python/sdk/authentication-overview.md 💡Suggestion Details

articles/python/sdk/authentication-azure-hosted-apps.md

  • Line 120, Column 244: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/storage/common/storage-account-overview' will be broken in isolated environments. Replace with a relative link.

articles/python/sdk/authentication-local-development-dev-accounts.md

  • Line 162, Column 667: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/storage/common/storage-account-overview' will be broken in isolated environments. Replace with a relative link.

articles/python/sdk/authentication-local-development-service-principal.md

  • Line 204, Column 517: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/storage/common/storage-account-overview' will be broken in isolated environments. Replace with a relative link.

articles/python/sdk/authentication-on-premises-apps.md

  • Line 130, Column 259: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/storage/common/storage-account-overview' will be broken in isolated environments. Replace with a relative link.

articles/python/sdk/authentication-overview.md

  • Line 64, Column 321: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/storage/common/storage-account-overview' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Jun 24, 2024

@bobtabor-msft

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jun 24, 2024
@bobtabor-msft bobtabor-msft requested a review from JimacoMS4 June 24, 2024 15:26
@bobtabor-msft
Copy link
Contributor

@Court72 ... Adding @JimacoMS4 who has been working on these docs recently. Hold off for now. Let's figure out the best place to put this kind of information (assuming we don't already have it somewhere).

@bobtabor-msft
Copy link
Contributor

@elainajones Thank you for your submission. There are some good ideas in this PR that we will want to apply more broadly, and some that we do not want to include. So, thank you again, great ideas and it brought to light the need to add a few things to certain docs ... so I'm going to close this PR, but this helped highlight some areas in our docs that can be improved. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants