Skip to content

Conversation

@AlexGuteniev
Copy link
Contributor

No description provided.

@PRMerger15
Copy link
Contributor

@AlexGuteniev : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver
Copy link
Contributor

#label:"aq-pr-triaged"

@PRMerger18 PRMerger18 added the aq-pr-triaged Tracking label for the PR review team label Oct 20, 2021
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thank you for taking an interest in the docs.
I'm not incorporating this change for two reasons.

  • Our docs reflect the signature according to our implementation, which isn't constexpr
  • I'm not sure the note is accurate, either. I'll take it up with the library team about adding an explanation as to why it isn't constexpr.

@AlexGuteniev
Copy link
Contributor Author

  • Our docs reflect the signature according to our implementation, which isn't constexpr

Currently it doesn't, this is what I want to fix.

  • I'm not sure the note is accurate, either. I'll take it up with the library team about adding an explanation as to why it isn't constexpr.

Ok.

I will prefer to either keep this PR open, or an issue created instead of it, to keep track of this.

@TylerMSFT
Copy link
Collaborator

TylerMSFT commented Oct 22, 2021

@AlexGueteniev, unfortunately, it's addressed to the wrong audience. The documentation team can't change the product. Instead, I recommend bringing this issue up on Developer Community, where it can be seen by the product team. They'll take this under consideration. In the meantime, I'm closing this as not a documentation issue.

@TylerMSFT TylerMSFT closed this Oct 22, 2021
@TylerMSFT
Copy link
Collaborator

@AlexGuteniev , I created an issue on the STL repo regarding this for you: microsoft/STL#2295

@TylerMSFT
Copy link
Collaborator

For the record, I read the diff wrong and we do need to remove constexpr from the std::mutex constructor. Which I've done.

@AlexGuteniev AlexGuteniev deleted the mutex branch October 23, 2021 03:39
@AlexGuteniev
Copy link
Contributor Author

@TylerMSFT
Copy link
Collaborator

No, it doesn't. Press. F5 to refresh the page in your browser.

@AlexGuteniev
Copy link
Contributor Author

No, it doesn't. Press. F5 to refresh the page in your browser.

I Confirm, it is updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants