-
Notifications
You must be signed in to change notification settings - Fork 981
Document std::mutex constructor nonconformance
#3467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@AlexGuteniev : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
#label:"aq-pr-triaged" |
TylerMSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thank you for taking an interest in the docs.
I'm not incorporating this change for two reasons.
- Our docs reflect the signature according to our implementation, which isn't constexpr
- I'm not sure the note is accurate, either. I'll take it up with the library team about adding an explanation as to why it isn't constexpr.
Currently it doesn't, this is what I want to fix.
Ok. I will prefer to either keep this PR open, or an issue created instead of it, to keep track of this. |
|
@AlexGueteniev, unfortunately, it's addressed to the wrong audience. The documentation team can't change the product. Instead, I recommend bringing this issue up on Developer Community, where it can be seen by the product team. They'll take this under consideration. In the meantime, I'm closing this as not a documentation issue. |
|
@AlexGuteniev , I created an issue on the STL repo regarding this for you: microsoft/STL#2295 |
|
For the record, I read the diff wrong and we do need to remove constexpr from the std::mutex constructor. Which I've done. |
|
It still says |
|
No, it doesn't. Press. F5 to refresh the page in your browser. |
I Confirm, it is updated |
No description provided.