Skip to content

Conversation

@branh
Copy link
Contributor

@branh branh commented Mar 13, 2024

Not all the ASAN code examples actually worked. Some of them require /Od.

This PR updates the examples to be more robust in the face of optimizations, and clarifies the examples where /Od is required and why. There is a corresponding internal PR to make sure we test that these examples still function every time we make changes.

@prmerger-automator
Copy link
Contributor

@branh : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Contributor

@branh : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 0a75a74:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/sanitizers/error-memcpy-param-overlap.md ⚠️Warning Details
docs/sanitizers/error-global-buffer-overflow.md ✅Succeeded
docs/sanitizers/error-stack-buffer-overflow.md ✅Succeeded
docs/sanitizers/error-stack-buffer-underflow.md ✅Succeeded
docs/sanitizers/error-stack-use-after-return.md ✅Succeeded
docs/sanitizers/error-stack-use-after-scope.md ✅Succeeded

docs/sanitizers/error-memcpy-param-overlap.md

  • Line 42, Column 5: [Warning: file-not-found - See documentation] Invalid file link: '../../build/reference/oi-generate-intrinsic-functions'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 99255ee:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/sanitizers/error-memcpy-param-overlap.md ⚠️Warning Details
docs/sanitizers/error-global-buffer-overflow.md ✅Succeeded
docs/sanitizers/error-stack-buffer-overflow.md ✅Succeeded
docs/sanitizers/error-stack-buffer-underflow.md ✅Succeeded
docs/sanitizers/error-stack-use-after-return.md ✅Succeeded
docs/sanitizers/error-stack-use-after-scope.md ✅Succeeded

docs/sanitizers/error-memcpy-param-overlap.md

  • Line 42, Column 5: [Warning: file-not-found - See documentation] Invalid file link: '../../build/reference/oi-generate-intrinsic-functions.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit c63bf71:

✅ Validation status: passed

File Status Preview URL Details
docs/sanitizers/error-global-buffer-overflow.md ✅Succeeded
docs/sanitizers/error-memcpy-param-overlap.md ✅Succeeded
docs/sanitizers/error-stack-buffer-overflow.md ✅Succeeded
docs/sanitizers/error-stack-buffer-underflow.md ✅Succeeded
docs/sanitizers/error-stack-use-after-return.md ✅Succeeded
docs/sanitizers/error-stack-use-after-scope.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great--thank you.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit c521b56:

✅ Validation status: passed

File Status Preview URL Details
docs/sanitizers/error-global-buffer-overflow.md ✅Succeeded
docs/sanitizers/error-memcpy-param-overlap.md ✅Succeeded
docs/sanitizers/error-stack-buffer-overflow.md ✅Succeeded
docs/sanitizers/error-stack-buffer-underflow.md ✅Succeeded
docs/sanitizers/error-stack-use-after-return.md ✅Succeeded
docs/sanitizers/error-stack-use-after-scope.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ShannonLeavitt ShannonLeavitt added the aq-pr-triaged Tracking label for the PR review team label Mar 14, 2024
@branh
Copy link
Contributor Author

branh commented Mar 20, 2024

#sign-off

@prmerger-automator
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @TylerMSFT

@TylerMSFT
Copy link
Collaborator

#sign-off

@Court72 Court72 merged commit 866d199 into MicrosoftDocs:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants